-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accessibility issues #1673
Fix accessibility issues #1673
Conversation
or focus is within parent container
This is off-topic, but for consistency, I think it would be better to remove the dependency on the "darkly" theme, which also changes the font size of menus and admonitions. |
Sorry for getting around to this earlier, but these changes all LGTM. Thanks @pfitzseb! I'd be happy to merge this in it's current form if you don't have additional fixes right now, since I think it's already an improvement.
Darkly (kinda) is the current dark theme.. so it would have to be replaced with something. So when you say "remove", do you mean reducing the current dark theme down to something that would just override the colors basically? If yes, then I would support that completely --- just dropping Darkly in was kind of a shortcut to get a working dark theme in quickly, but it's definitely not ideal. |
Yeah, I don't have any immediate plans to work on this further. There are some issues related to duplicate header ids, but I haven't yet have time to look into those. |
Good to go? Perhaps worth adding a note in the changelog? |
Yup, good to go. |
ac6821a
to
da2affa
Compare
The goal of this is to make sure Documenter-generated docs conform to WCAG 2.0.
I'm opening this early so I can document the changes as I work my way through them, which should hopefully make review a bit easier.
Color contrast
Light theme
Version
contrastFrom: Contrast ratio 3.93
To: Contrast ratio 5.26
Dark theme code contrast
From: Contrast ratio 3.55
To: Contrast ratio 11.49
Elements
Nested lists in content
Currently, nested lists are rendered as
Having a
ul
as the direct child of anotherul
is invalid, so 01fb501 changes that towithout any difference in presentation.
Focus handling
Source link
The source link is not shown when tabbing through the page content. This PR will show the button at full opacity when it's focused
and at 0.2 opacity when something in the
.docstring
container is focused: